add support for empty result set with selectOne #108
Conversation
| (fn [handler] | ||
| (fn [req] | ||
| (let [{:keys [status body] :as result} (handler req)] | ||
| (if (and (= 200 status) (nil? body)) |
There was a problem hiding this comment.
This feels like something that should be handled by muuntaja instead of rolling our own conversion for this specific case. Is there no way to accomplish this using that library since we're already using it to convert between formats? I can see this causing issues if we ever decide to respond with edn as well as json.
There was a problem hiding this comment.
I gave it an honest try with muuntaja but wasn't willing to devote more than 2 hours to it. Once I couldn't get it working in that window I went back to this. I figure that if we ever do support edn there will need to be a lot of updates to the middleware anyways.
There was a problem hiding this comment.
Is this a problem with the QureryResponse schema? What happens when you just account for the possibility that :select-one query responses can also be nil?
There was a problem hiding this comment.
Then it converts the :body key to the empty string "", which isn't valid json.
I've mapped a
nilresult when aselectOnequery returns no results to the JSON string "null", which parses tonullin Javascript. Without this support the response fails to conform to theQueryResponseschema.